Revert "Pre linux.pagecache.recoverfs support"#1563
Conversation
|
@Abyss-W4tcher Apologies for this; I didn't mean to interfere with your work. I know this is frustrating but the issue isn't just about resolving a merge conflict. I'm currently running a large set of semi-automated (or more accurately, semi-manual) tests locally. It’s taking quite some time and requires thorough manual supervision to review the results. Additionally, @atcuno is running a much larger set of tests on his side and reviewing each sample individually. Given this, we want to avoid introducing additional changes that could complicate the situation further. We're close to finishing up the remaining tickets, so it shouldn't take much longer. Hopefully, we'll soon have better sample coverage in the GitHub test cases. Thanks for your understanding |
|
Hi, no worries, this PR is also a work towards a vol2 plugin parity but given the context it can wait a few more days 👍. |
|
@gcmoreira Hi, do you think I can push the PR again now ? |
|
I think it's probably fine, but you'll need to submit it as a new PR please... |
|
Yes of course, the previous changes have merge conflicts anyway 👍. |
3 participants
Reverts #1561
As requested, temporarily reverting this while work is done to the pagecache areas. It might be easiest all round for this to get a new PR to be applied again (with a big notice not to apply until another issue has been resolved, or just a clear flag to indicate what's being worked on).
Also, since I don't know which bits you guys are working on, could you please keep an eye out for PRs and flag that they shouldn't be applied yet in some way please? This one did only arrive 9 hours ago, so you won't necessarily have had time to see it/comment on it, so I'm ok reverting in this instance. But in general, I'm not sure it's fair to play favourites with more notice of which areas are under construction and keeping an eye out for PRs that may conflict. Resolve merge conflicts should be par for the course, and I'd like us to get used to them rather than revert when they crop up in the future...