Skip to content

chore(ci): pin ruff#1571

Closed
c0rydoras wants to merge 1 commit intovolatilityfoundation:developfrom
c0rydoras:chore/ci/pin-ruff
Closed

chore(ci): pin ruff#1571
c0rydoras wants to merge 1 commit intovolatilityfoundation:developfrom
c0rydoras:chore/ci/pin-ruff

Conversation

@c0rydoras
Copy link
Contributor

@c0rydoras c0rydoras commented Jan 24, 2025

pin ruff in ci, so that new ruff releases don't cause previously passing checks to fail

@ikelos
Copy link
Member

ikelos commented Jan 25, 2025

I'm not convinced we want to pin ourselves, we'd have to remember to update at some point and then fix all the differences, rather than fix them as they crop up? That feels like it'll be more work just to keep some tests from breaking and identifying the fixes at the point they'd happen? We can apply any non-related changes to the main tree if people don't want to put them in a separate commit in their PR, either way it feels like less work to keep current than to bunch up issues and have to fix them all at once? Also, we don't have stats on how often ruff changes rules?

@ikelos
Copy link
Member

ikelos commented Jan 30, 2025

Thanks for the suggestion, but we're going to live with the pain and make sure we test against the latest suggestions and issues that ruff identifies. Marking this as closed.

@ikelos ikelos closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants