Skip to content

fix missed lifecycle shutdown time update in sandbox helper test #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volcano-sh-bot merged 2 commits into from
Feb 6, 2026
Merged

fix missed lifecycle shutdown time update in sandbox helper test #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2add7c0
fix sandbox helper test for lifecycle shutdown time
acsoto Feb 6, 2026
eac0963
fix auth middleware parsing test token format
acsoto Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/workloadmanager/auth_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"fmt"
"net/http"
"net/http/httptest"
"strings"
"testing"
"time"

Expand Down Expand Up @@ -223,7 +224,7 @@ func TestAuthMiddleware_ServiceAccountParsing(t *testing.T) {

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
token := "token-" + tt.name
token := "token-" + strings.ReplaceAll(tt.name, " ", "-")
server.tokenCache.Set(token, true, tt.username)

w := httptest.NewRecorder()
Expand Down
4 changes: 3 additions & 1 deletion pkg/workloadmanager/sandbox_helper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ func TestBuildSandboxInfo_TableDriven(t *testing.T) {
CreationTimestamp: metav1.NewTime(now),
},
Spec: sandboxv1alpha1.SandboxSpec{
ShutdownTime: &metav1.Time{Time: shutdownTime},
Copy link
Copy Markdown
Member

@hzxuzhonghu hzxuzhonghu Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both are right,

	// Lifecycle defines when and how the sandbox should be shut down.
	// +optional
	Lifecycle `json:",inline"`

Lifecycle: sandboxv1alpha1.Lifecycle{
ShutdownTime: &metav1.Time{Time: shutdownTime},
},
},
Status: sandboxv1alpha1.SandboxStatus{
Conditions: []metav1.Condition{
Expand Down
Loading