add introduce sandbox warm pool proposal

[LiZhenCheng9527]

add introduce sandbox warm pool proposal

• Add sandboxWarmpool interface
• Add sandboxTemplate interface
• Use sandboxClaim to create sandbox

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @LiZhenCheng9527, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a comprehensive proposal for implementing a sandbox warm pool mechanism to significantly reduce the latency associated with sandbox instance preparation. It outlines new administrative interfaces for managing SandboxWarmpool and SandboxTemplate resources, detailing their CRUD operations and how they will integrate with the existing sandboxClaim process to enable faster sandbox provisioning and improved system responsiveness.

Highlights

• Sandbox Warm Pool Proposal: A new proposal document has been added that outlines the introduction of a sandbox warm pool to reduce instance preparation latency.
• SandboxWarmpool Interface: The proposal defines a programmatic interface for administrators to perform CRUD (Create, Read, Update, Delete) operations on SandboxWarmpool resources, including new API handlers.
• SandboxTemplate Interface: An interface for managing SandboxTemplate resources is introduced, which are essential for the functionality of sandboxClaim and warm pools, also with dedicated CRUD API handlers.
• SandboxClaim Integration: The proposal details how sandboxClaim will be integrated to leverage sandboxTemplates and warm pools for creating sandboxes, aiming to speed up the provisioning process.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a design proposal for a sandbox warm pool feature. The proposal is well-structured and covers the motivation, goals, and implementation details. I've provided some feedback on the proposal document, mainly focusing on improving the clarity of the API design and some parts of the implementation description. There are a few typos and areas that could be rephrased for better understanding. Additionally, a template file seems to have been included, which might not be necessary for this PR. Overall, this is a good proposal that will benefit from some minor refinements.

[gemini-code-assist]

This file appears to be a generic template for proposals. Given the pull request is about adding the "sandbox warm pool proposal", was this template file intended to be included? It seems like sandbox-warmpool-proposal.md is the actual proposal, and this is the unfilled template it was based on. If it's not needed, it should probably be removed from this PR to avoid confusion.

[LiZhenCheng9527]

@hzxuzhonghu Please help review it again.

[hzxuzhonghu]

Overall, it contains so many interference element. Please read https://www.edrawsoft.cn/what-is-flowchart/

The flow element should be a operation rather than simple noun

[hzxuzhonghu]

I would suggest we split the warmpool usage:

1. how admin create a warmpool. This part is already covered，but lack of good heading #### sandboxWarmpool Interface
2. how does agentcube-apiserver handle sandbox creation from warmpool.

Split the flow chart