-
Notifications
You must be signed in to change notification settings - Fork 101
feat: add selectabledfield for queue and podgroup #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add selectabledfield `parent` for Queue, so user can list queues with specific parent queue. - Add selectabledfiled `queue` for PodGroup, so user can list podgroups with specific queue. Signed-off-by: xuwentao <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @Xu-Wentao! It looks like this is your first PR to volcano-sh/apis 🎉 |
Summary of ChangesHello @Xu-Wentao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces selectablefield markers for PodGroup.spec.queue and Queue.spec.parent. This is a valuable enhancement that enables server-side filtering on these fields, which will improve the performance and usability of listing these resources with filters. The implementation is correct and follows standard kubebuilder conventions. The code changes look good. As a minor note, there are a couple of typos ('selectabledfield', 'selectabledfiled') in the pull request title and description, which you might want to correct for clarity.
parentfor Queue, so user can list queues with specific parent queue.queuefor PodGroup, so user can list podgroups with specific queue.