Skip to content

Conversation

@Xu-Wentao
Copy link

  • Add selectabledfield parent for Queue, so user can list queues with specific parent queue.
  • Add selectabledfiled queue for PodGroup, so user can list podgroups with specific queue.

- Add selectabledfield `parent` for  Queue, so user can list queues with specific parent queue.
- Add selectabledfiled `queue` for PodGroup, so user can list podgroups with specific queue.

Signed-off-by: xuwentao <[email protected]>
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign william-wang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
Copy link
Collaborator

Welcome @Xu-Wentao! It looks like this is your first PR to volcano-sh/apis 🎉

@gemini-code-assist
Copy link

Summary of Changes

Hello @Xu-Wentao, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Queue and PodGroup custom resources by introducing new selectablefield annotations. These additions improve the usability of kubectl by allowing users to easily filter and list these resources based on their parent queue for Queue objects and their queue for PodGroup objects, streamlining resource management and querying capabilities.

Highlights

  • PodGroup Selectable Field: Added a selectablefield annotation for the spec.queue field of the PodGroup custom resource, enabling users to list PodGroups filtered by their associated queue.
  • Queue Selectable Field: Added a selectablefield annotation for the spec.parent field of the Queue custom resource, allowing users to list Queues filtered by their parent queue.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces selectablefield markers for PodGroup.spec.queue and Queue.spec.parent. This is a valuable enhancement that enables server-side filtering on these fields, which will improve the performance and usability of listing these resources with filters. The implementation is correct and follows standard kubebuilder conventions. The code changes look good. As a minor note, there are a couple of typos ('selectabledfield', 'selectabledfiled') in the pull request title and description, which you might want to correct for clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants