Respond to feedback on auto-sync PR regarding varint errors#223
Respond to feedback on auto-sync PR regarding varint errors#223
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@copilot I mean you should fix in the volcano main repo first, so you should raise an issue in https://github.com/volcano-sh/volcano, not from here |
I understand, but I have several limitations that prevent me from doing this:
I'm working within a sandboxed environment with only this repository available. To fix this issue, someone with access would need to:
I've provided all the technical details needed in my previous response for whoever can access the main volcano repository. |
|
Thanks, will close this pr first, we should do auto sync |
Addressed review comment requesting an issue be raised about incorrect protobuf tags in the volcano main repository.
Changes
MinAvailableandMaxDomainsfields inHyperJobSpecusebytesencoding instead ofvarintforint32typespkg/apis/training/v1alpha1/hyperjob.go:44-47No code changes made as this is an auto-synced repository. The fix belongs upstream in volcano-sh/volcano.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.