Skip to content

Respond to feedback on auto-sync PR regarding varint errors#223

Closed
Copilot wants to merge 1 commit intomasterfrom
copilot/sub-pr-222
Closed

Respond to feedback on auto-sync PR regarding varint errors#223
Copilot wants to merge 1 commit intomasterfrom
copilot/sub-pr-222

Conversation

Copy link

Copilot AI commented Jan 16, 2026

Addressed review comment requesting an issue be raised about incorrect protobuf tags in the volcano main repository.

Changes

  • Replied to comment explaining I cannot create GitHub issues directly
  • Provided complete issue details for maintainer to create:
    • Problem: MinAvailable and MaxDomains fields in HyperJobSpec use bytes encoding instead of varint for int32 types
    • Location: pkg/apis/training/v1alpha1/hyperjob.go:44-47
    • Impact: Can cause protobuf serialization issues
    • Fix location: Main volcano repository (this is an auto-sync repo)

No code changes made as this is an auto-synced repository. The fix belongs upstream in volcano-sh/volcano.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot AI changed the title [WIP] Address feedback on auto-sync PR and varint error Respond to feedback on auto-sync PR regarding varint errors Jan 16, 2026
@JesseStutler
Copy link
Member

@copilot I mean you should fix in the volcano main repo first, so you should raise an issue in https://github.com/volcano-sh/volcano, not from here

Copy link
Author

Copilot AI commented Jan 16, 2026

@copilot I mean you should fix in the volcano main repo first, so you should raise an issue in https://github.com/volcano-sh/volcano, not from here

I understand, but I have several limitations that prevent me from doing this:

  1. I cannot create issues in GitHub repositories
  2. I cannot clone or access the volcano-sh/volcano repository (I only have access to this apis repository)
  3. I cannot create PRs in other repositories

I'm working within a sandboxed environment with only this repository available. To fix this issue, someone with access would need to:

  • Create an issue in volcano-sh/volcano repository describing the protobuf tag problem
  • Make the fix in volcano-sh/volcano (changing bytes to varint for the int32 fields)
  • The fix will then sync to this apis repository automatically

I've provided all the technical details needed in my previous response for whoever can access the main volcano repository.

Base automatically changed from sync-15d1759d7 to master January 16, 2026 02:05
@JesseStutler
Copy link
Member

Thanks, will close this pr first, we should do auto sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments