fix: correct typo in vcjob completed state description#489
fix: correct typo in vcjob completed state description#489ldsdsy wants to merge 1 commit intovolcano-sh:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @ldsdsy! It looks like this is your first PR to volcano-sh/website 🎉 |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important documentation error by rectifying a typo in the Chinese Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request corrects a typo in the Chinese documentation for vcjob across multiple versions. In addition to this fix, I've provided suggestions to improve readability by adding a space between English words and Chinese characters, which is a common best practice for mixed-language text.
Note: Security Review has been skipped due to the limited scope of the PR.
| * completed | ||
|
|
||
| completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 | ||
| completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 |
There was a problem hiding this comment.
| * completed | ||
|
|
||
| completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 | ||
| completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 |
There was a problem hiding this comment.
| * completed | ||
|
|
||
| completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 | ||
| completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 |
There was a problem hiding this comment.
| * completed | ||
|
|
||
| completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 | ||
| completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 |
There was a problem hiding this comment.
| * completed | ||
|
|
||
| completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 | ||
| completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 |
There was a problem hiding this comment.
| * completed | ||
|
|
||
| completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 | ||
| completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 |
There was a problem hiding this comment.
| * completed | ||
|
|
||
| completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 | ||
| completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。 |
There was a problem hiding this comment.
The completed state description incorrectly started with "completing" instead of "completed" across all versioned docs. Made-with: Cursor Signed-off-by: ldsdsy <ldsdsyll@outlook.com>
8f4ca4c to
e03e901
Compare
|
/lgtm |
The completed state description incorrectly started with "completing" instead of "completed" across all versioned docs.
/kind documentation
What this PR does / why we need it:
Fix a typo in vcjob docs: under the
completedstate section, the description incorrectly starts with "completing" instead of "completed". Fixed across all versioned docs (v1-7-0, v1-8-2, v1-9-0, v1-10-0, v1-11-0, v1-12-0, and latest).Which issue(s) this PR fixes:
None