Skip to content

fix: correct typo in vcjob completed state description#489

Open
ldsdsy wants to merge 1 commit intovolcano-sh:masterfrom
ldsdsy:fix/docs-vcjob-completed-typo
Open

fix: correct typo in vcjob completed state description#489
ldsdsy wants to merge 1 commit intovolcano-sh:masterfrom
ldsdsy:fix/docs-vcjob-completed-typo

Conversation

@ldsdsy
Copy link

@ldsdsy ldsdsy commented Mar 11, 2026

The completed state description incorrectly started with "completing" instead of "completed" across all versioned docs.

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

/kind documentation

  • What this PR does / why we need it:
    Fix a typo in vcjob docs: under the completed state section, the description incorrectly starts with "completing" instead of "completed". Fixed across all versioned docs (v1-7-0, v1-8-2, v1-9-0, v1-10-0, v1-11-0, v1-12-0, and latest).

  • Which issue(s) this PR fixes:
    None

@volcano-sh-bot volcano-sh-bot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 11, 2026
@volcano-sh-bot volcano-sh-bot requested review from Arhell and k82cn March 11, 2026 06:54
@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jessestutler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot
Copy link
Collaborator

Welcome @ldsdsy! It looks like this is your first PR to volcano-sh/website 🎉

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important documentation error by rectifying a typo in the Chinese vcjob documentation. The fix ensures accuracy in describing the completed state across various versioned documents, thereby improving clarity and correctness for users reading the Chinese documentation.

Highlights

  • Documentation Correction: Corrected a typo in the description of the 'completed' state for vcjob within Chinese documentation files across multiple versions. The incorrect term 'completing' was replaced with 'completed'.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • content/zh/docs/v1-10-0/vcjob.md
    • Corrected a typo in the 'completed' state description, changing 'completing' to 'completed'.
  • content/zh/docs/v1-11-0/vcjob.md
    • Corrected a typo in the 'completed' state description, changing 'completing' to 'completed'.
  • content/zh/docs/v1-12-0/vcjob.md
    • Corrected a typo in the 'completed' state description, changing 'completing' to 'completed'.
  • content/zh/docs/v1-7-0/vcjob.md
    • Corrected a typo in the 'completed' state description, changing 'completing' to 'completed'.
  • content/zh/docs/v1-8-2/vcjob.md
    • Corrected a typo in the 'completed' state description, changing 'completing' to 'completed'.
  • content/zh/docs/v1-9-0/vcjob.md
    • Corrected a typo in the 'completed' state description, changing 'completing' to 'completed'.
  • content/zh/docs/vcjob.md
    • Corrected a typo in the 'completed' state description, changing 'completing' to 'completed'.
Activity
  • Pull request was opened by ldsdsy to fix a documentation typo.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo in the Chinese documentation for vcjob across multiple versions. In addition to this fix, I've provided suggestions to improve readability by adding a space between English words and Chinese characters, which is a common best practice for mixed-language text.

Note: Security Review has been skipped due to the limited scope of the PR.

* completed

completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability, it's a good practice to add a space between English words and Chinese characters. This helps to visually separate them.

Suggested change
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed 表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

* completed

completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability, it's a good practice to add a space between English words and Chinese characters. This helps to visually separate them.

Suggested change
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed 表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

* completed

completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability, it's a good practice to add a space between English words and Chinese characters. This helps to visually separate them.

Suggested change
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed 表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

* completed

completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability, it's a good practice to add a space between English words and Chinese characters. This helps to visually separate them.

Suggested change
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed 表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

* completed

completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability, it's a good practice to add a space between English words and Chinese characters. This helps to visually separate them.

Suggested change
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed 表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

* completed

completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability, it's a good practice to add a space between English words and Chinese characters. This helps to visually separate them.

Suggested change
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed 表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

* completed

completing表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved readability, it's a good practice to add a space between English words and Chinese characters. This helps to visually separate them.

Suggested change
completed表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。
completed 表示job中至少有minAvailable个数的task已经完成,该job已经完成了最后的清理工作。

The completed state description incorrectly started with "completing"
instead of "completed" across all versioned docs.

Made-with: Cursor
Signed-off-by: ldsdsy <ldsdsyll@outlook.com>
@ldsdsy ldsdsy force-pushed the fix/docs-vcjob-completed-typo branch from 8f4ca4c to e03e901 Compare March 11, 2026 07:08
@hwdef
Copy link
Member

hwdef commented Mar 11, 2026

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants