fix:template and add requirement.txt#102
Merged
yaozheng-fang merged 2 commits intomainfrom Aug 26, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a template script and adds security configuration. The main purpose is to improve the deployment script's dependency management and add proper environment variable validation while configuring security scanning rules.
- Enhanced dependency installation with conditional checks for FastAPI and Uvicorn
- Added validation for the MODEL_AGENT_API_KEY environment variable
- Updated GitLeaks configuration to allow requirements.txt files
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| veadk/integrations/ve_faas/template/{{cookiecutter.local_dir_name}}/src/run.sh | Enhanced script with conditional dependency installation and environment variable validation |
| .gitleaks.toml | Added allowlist for requirements.txt files in security scanning |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
|
||
| # in case of deployment deps not installed in user's requirements.txt | ||
| python3 -m pip install uvicorn[standard] fastapi | ||
| if pip list | grep "^fastapi \|^uvicorn "; then |
There was a problem hiding this comment.
The grep pattern will only succeed if both fastapi AND uvicorn are installed due to the pipe operator. This should use separate checks or modify the pattern to check for either package independently.
Suggested change
| if pip list | grep "^fastapi \|^uvicorn "; then | |
| if pip list | grep "^fastapi " >/dev/null && pip list | grep "^uvicorn " >/dev/null; then |
veadk/integrations/ve_faas/template/{{cookiecutter.local_dir_name}}/src/run.sh
Outdated
Show resolved
Hide resolved
LotsoTeddy
approved these changes
Aug 26, 2025
…ame}}/src/run.sh Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
yaozheng-fang
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.