Skip to content

Fix: Handle SIGINT and Print Final Output Before Process Exit #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Fix: Handle SIGINT and Print Final Output Before Process Exit #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 29 additions & 3 deletions src/ProcessManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ class ProcessManager
private string $binaryPath;

private $currentProcess = null;
private mixed $pipes;

public function __construct(string $binaryPath)
{
Expand All @@ -20,19 +21,41 @@ public function __construct(string $binaryPath)
}
}

private function handleSignal(int $signal): void
public function handleSignal(int $signal): void
{
if ($this->currentProcess && is_resource($this->currentProcess)) {
proc_terminate($this->currentProcess);
// Send SIGTERM to the process
proc_terminate($this->currentProcess, SIGTERM);

// Wait a bit for it to exit gracefully
sleep(1);

// Capture final output before closing the process
$output = '';
if ($this->pipes && isset($this->pipes[1]) && is_resource($this->pipes[1])) {
stream_set_blocking($this->pipes[1], false); // Ensure non-blocking mode
$output = stream_get_contents($this->pipes[1]);
fclose($this->pipes[1]);
}

// Ensure the process is closed
proc_close($this->currentProcess);
$this->currentProcess = null;

// Print the final output
if (!empty($output)) {
echo "\n$output\n";
}
}

exit(0);
}

public function execute(array $config, bool $streamOutput): string
{
[$success, $process, $pipes] = $this->openProcess();
$this->currentProcess = $process;
$this->pipes = $pipes;

if (! $success || ! is_array($pipes)) {
throw new RuntimeException('Failed to start process of volt test');
Expand Down Expand Up @@ -109,6 +132,10 @@ private function handleProcess(array $pipes, bool $streamOutput): string
{
$output = '';

// Set non-blocking mode for stdout and stderr
stream_set_blocking($pipes[1], false);
stream_set_blocking($pipes[2], false);

while (true) {
$read = array_filter($pipes, 'is_resource');
if (empty($read)) {
Expand All @@ -130,7 +157,6 @@ private function handleProcess(array $pipes, bool $streamOutput): string
if (feof($pipe)) {
fclose($pipe);
unset($pipes[$type]);

continue;
}
}
Expand Down