Skip to content

fix: don't produce vortex ffi dylib #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0ax1 merged 2 commits into from
Apr 25, 2025
Merged

fix: don't produce vortex ffi dylib #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d11eeb6
fix: always link static ffi lib into ddb extension
0ax1 Apr 25, 2025
fd23d56
fix: static ffi lib only
0ax1 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/MainDistributionPipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
#
name: Main Extension Distribution Pipeline
on:
pull_request:
push:
branches: [ "main" ]
pull_request: { }

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref || '' }}-${{ github.base_ref || '' }}-${{ github.ref != 'refs/heads/main' || github.sha }}
Expand Down
8 changes: 2 additions & 6 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ endif ()
corrosion_import_crate(MANIFEST_PATH vortex/Cargo.toml
CRATES vortex-ffi
FEATURES duckdb
IMPORTED_CRATES vortex_ffi
CRATE_TYPES staticlib
FLAGS --crate-type=staticlib
)

set(EXTENSION_NAME ${TARGET_NAME}_extension)
Expand All @@ -47,11 +48,6 @@ target_link_libraries(${EXTENSION_NAME}
protobuf::libprotobuf
${SECURITY_FRAMEWORK}
)
target_link_libraries(${LOADABLE_EXTENSION_NAME}
vortex_ffi-shared
protobuf::libprotobuf
${SECURITY_FRAMEWORK}
)

add_subdirectory(test)

Expand Down
Loading