fix[dict]: min_max must not be null

joseph-isaacs · joseph-isaacs · commit 186957366b4e · 2025-11-27T13:47:28.000Z
Signed-off-by: Joe Isaacs &lt;joe.isaacs@live.co.uk&gt;
diff --git a/vortex-layout/src/layouts/dict/reader.rs b/vortex-layout/src/layouts/dict/reader.rs
@@ -177,10 +177,12 @@ impl LayoutReader for DictReader {
             if values.all_valid()
                 && let Some(MinMaxResult { min, max }) = min_max(&values)?
             {
+                #[expect(clippy::bool_comparison, reason = "easy to follow")]
                 if max.as_bool().value().vortex_expect("non null") == false {
                     // All values are false
                     return Ok(Mask::AllFalse(mask.len()));
                 }
+                #[expect(clippy::bool_comparison, reason = "easy to follow")]
                 if min.as_bool().value().vortex_expect("not null") == true {
                     // All values are true, but we still need to respect codes validity
                     return Ok(mask.bitand(&codes.validity_mask()));

Original file line number	Diff line number	Diff line change
`@@ -177,10 +177,12 @@ impl LayoutReader for DictReader {`
`177`	`177`	`if values.all_valid()`
`178`	`178`	`&& let Some(MinMaxResult { min, max }) = min_max(&values)?`
`179`	`179`	`{`
	`180`	`+ #[expect(clippy::bool_comparison, reason = "easy to follow")]`
`180`	`181`	`if max.as_bool().value().vortex_expect("non null") == false {`
`181`	`182`	`// All values are false`
`182`	`183`	`return Ok(Mask::AllFalse(mask.len()));`
`183`	`184`	`}`
	`185`	`+ #[expect(clippy::bool_comparison, reason = "easy to follow")]`
`184`	`186`	`if min.as_bool().value().vortex_expect("not null") == true {`
`185`	`187`	`// All values are true, but we still need to respect codes validity`
`186`	`188`	`return Ok(mask.bitand(&codes.validity_mask()));`