Skip to content

Commit 2c7a641

Browse files
committed
clippy
Signed-off-by: Andrew Duffy <[email protected]>
1 parent 8a038fc commit 2c7a641

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

vortex-vector/src/binaryview/types.rs

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,14 @@ pub trait BinaryViewType: Debug + Sized + private::Sealed {
2929

3030
/// Returns the bytes as the native `Slice` type
3131
/// for this binary view vector.
32+
///
33+
/// # Safety
34+
///
35+
/// The caller must check beforehand that bytes return from the vector conform to the type
36+
/// requirements of this binary type.
37+
///
38+
/// Failure to do so can result in undefined behavior or incorrect results in downstream
39+
/// vector operations.
3240
unsafe fn from_bytes_unchecked(bytes: &[u8]) -> &Self::Slice;
3341

3442
/// Downcast the provided object to a type-specific instance.

vortex-vector/src/binaryview/view.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,6 @@ where
284284
ValidateFn: Fn(&[u8]) -> bool,
285285
{
286286
let buffers = buffers.as_ref();
287-
let views = views.as_ref();
288287
for (idx, &view) in views.iter().enumerate() {
289288
if !validity(idx) {
290289
continue;

0 commit comments

Comments
 (0)