Skip to content

Commit 386556b

Browse files
authored
Fix: delay getting benchmarks s3 token until after binary has been built (#3638)
Signed-off-by: Robert Kruszewski <[email protected]>
1 parent 8ac9f67 commit 386556b

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

.github/workflows/generate-benchmarks-s3.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ jobs:
2424
- disk=large
2525
- extras=s3-cache
2626
steps:
27+
- uses: runs-on/action@v2
2728
- uses: actions/checkout@v4
2829
with:
2930
submodules: "recursive"

.github/workflows/sql-benchmarks.yml

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ jobs:
4343
- spot=false
4444
- extras=s3-cache
4545
- tag=${{ matrix.id }}
46-
4746
steps:
4847
- uses: runs-on/action@v2
4948
with:
@@ -66,13 +65,6 @@ jobs:
6665
wget -qO- https://github.com/duckdb/duckdb/releases/download/v1.3.0/duckdb_cli-linux-amd64.zip | funzip > duckdb
6766
chmod +x duckdb
6867
echo "$PWD" >> $GITHUB_PATH
69-
70-
- name: Setup AWS CLI
71-
uses: aws-actions/configure-aws-credentials@v4
72-
with:
73-
role-to-assume: arn:aws:iam::375504701696:role/GitHubBenchmarkRole
74-
aws-region: us-east-1
75-
7668
- name: Build binary
7769
shell: bash
7870
env:
@@ -93,6 +85,12 @@ jobs:
9385
target/release_debug/${{ matrix.binary_name }} --targets datafusion:vortex -i1 -d gh-json
9486
target/release_debug/${{ matrix.binary_name }} --targets duckdb:vortex -i1 -d gh-json
9587
88+
- name: Setup AWS CLI
89+
uses: aws-actions/configure-aws-credentials@v4
90+
with:
91+
role-to-assume: arn:aws:iam::375504701696:role/GitHubBenchmarkRole
92+
aws-region: us-east-1
93+
9694
- name: Upload data
9795
if: matrix.remote_storage != null
9896
shell: bash

0 commit comments

Comments
 (0)