fix

Signed-off-by: Joe Isaacs <[email protected]>

Author: joseph-isaacs

vortex-layout/src/layouts/dict/mod.rs

@@ -115,12 +115,10 @@ impl VTable for DictVTable {
             // see [`SerdeVTable<DictVTable>::build`].
             .unwrap_or_else(|| dtype.nullability());
         let codes = children.child(1, &DType::Primitive(metadata.codes_ptype(), codes_nullable))?;
-        let all_values_referenced = metadata.all_values_referenced.unwrap_or(false);
-        Ok(DictLayout::new_with_metadata(
-            values,
-            codes,
-            all_values_referenced,
-        ))
+        Ok(unsafe {
+            DictLayout::new(values, codes)
+                .set_all_values_referenced(metadata.all_values_referenced.unwrap_or(false))
+        })
     }
 }
 
@@ -138,18 +136,19 @@ pub struct DictLayout {
 }
 
 impl DictLayout {
-    pub(crate) fn new_with_metadata(
-        values: LayoutRef,
-        codes: LayoutRef,
-        all_values_referenced: bool,
-    ) -> Self {
+    pub(crate) fn new(values: LayoutRef, codes: LayoutRef) -> Self {
         Self {
             values,
             codes,
-            all_values_referenced,
+            all_values_referenced: false,
         }
     }
 
+    pub unsafe fn set_all_values_referenced(mut self, all_values_referenced: bool) -> Self {
+        self.all_values_referenced = all_values_referenced;
+        self
+    }
+
     pub fn has_all_values_referenced(&self) -> bool {
         self.all_values_referenced
     }

vortex-layout/src/layouts/dict/writer.rs

@@ -182,9 +182,7 @@ impl LayoutStrategy for DictStrategy {
             .map(|result| {
                 let (codes_layout, values_layout) = result?;
                 // All values are referenced when created via dictionary encoding
-                Ok::<_, VortexError>(
-                    DictLayout::new_with_metadata(values_layout, codes_layout, true).into_layout(),
-                )
+                Ok::<_, VortexError>(DictLayout::new(values_layout, codes_layout).into_layout())
             })
             .try_collect::<Vec<_>>()
             .await?;