Skip to content

Commit a81b0e8

Browse files
committed
fix[dict]: not (filter/take) set_all_values_referenced
Signed-off-by: Joe Isaacs <[email protected]>
1 parent 08b0c52 commit a81b0e8

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

vortex-array/src/arrays/dict/array.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@ use std::hash::Hash;
66

77
use vortex_buffer::{BitBuffer, ByteBuffer};
88
use vortex_dtype::{DType, Nullability, PType, match_each_integer_ptype};
9-
use vortex_error::{VortexExpect, VortexResult, vortex_bail, vortex_ensure, vortex_err};
9+
use vortex_error::{
10+
VortexExpect, VortexResult, VortexUnwrap, vortex_bail, vortex_ensure, vortex_err,
11+
};
1012
use vortex_mask::{AllOr, Mask};
1113

1214
use crate::builders::dict::dict_encode;
@@ -163,14 +165,13 @@ impl DictArray {
163165
/// This is typically only set to `true` during dictionary encoding when we know for certain
164166
/// that all values are referenced.
165167
pub unsafe fn set_all_values_referenced(mut self, all_values_referenced: bool) -> Self {
166-
// In debug builds, verify the claim when setting to true
168+
self.all_values_referenced = all_values_referenced;
169+
167170
#[cfg(debug_assertions)]
168171
{
169-
use vortex_error::VortexUnwrap;
170172
self.validate_all_values_referenced().vortex_unwrap()
171173
}
172174

173-
self.all_values_referenced = all_values_referenced;
174175
self
175176
}
176177

0 commit comments

Comments
 (0)