Skip to content

Commit 88f8f42

Browse files
authored
fix: don't clone in micro-benchmarks (#5573)
Signed-off-by: Alexander Droste <[email protected]>
1 parent 85c2e2f commit 88f8f42

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

vortex/benches/single_encoding_throughput.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ fn bench_bitpacked_compress_u32(bencher: Bencher) {
9292
let bit_width = 8;
9393

9494
with_counter!(bencher, NUM_VALUES * 4)
95-
.with_inputs(|| &uint_array)
96-
.bench_refs(|a| unsafe { bitpack_encode_unchecked(a.clone(), bit_width).unwrap() });
95+
.with_inputs(|| uint_array.clone())
96+
.bench_values(|a| unsafe { bitpack_encode_unchecked(a, bit_width).unwrap() });
9797
}
9898

9999
#[divan::bench(name = "bitpacked_decompress_u32")]
@@ -114,8 +114,8 @@ fn bench_runend_compress_u32(bencher: Bencher) {
114114
let (uint_array, ..) = setup_primitive_arrays();
115115

116116
with_counter!(bencher, NUM_VALUES * 4)
117-
.with_inputs(|| &uint_array)
118-
.bench_refs(|a| RunEndArray::encode(a.clone().into_array()).unwrap());
117+
.with_inputs(|| uint_array.clone())
118+
.bench_values(|a| RunEndArray::encode(a.into_array()).unwrap());
119119
}
120120

121121
#[divan::bench(name = "runend_decompress_u32")]
@@ -158,8 +158,8 @@ fn bench_for_compress_i32(bencher: Bencher) {
158158
let (_, int_array, _) = setup_primitive_arrays();
159159

160160
with_counter!(bencher, NUM_VALUES * 4)
161-
.with_inputs(|| &int_array)
162-
.bench_refs(|a| FoRArray::encode(a.clone()).unwrap());
161+
.with_inputs(|| int_array.clone())
162+
.bench_values(|a| FoRArray::encode(a).unwrap());
163163
}
164164

165165
#[divan::bench(name = "for_decompress_i32")]
@@ -196,8 +196,8 @@ fn bench_zigzag_compress_i32(bencher: Bencher) {
196196
let (_, int_array, _) = setup_primitive_arrays();
197197

198198
with_counter!(bencher, NUM_VALUES * 4)
199-
.with_inputs(|| &int_array)
200-
.bench_refs(|a| zigzag_encode(a.clone()).unwrap());
199+
.with_inputs(|| int_array.clone())
200+
.bench_values(|a| zigzag_encode(a).unwrap());
201201
}
202202

203203
#[divan::bench(name = "zigzag_decompress_i32")]

0 commit comments

Comments
 (0)