feat: teach RunEndArray NullCount and TrueCount #2007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
reviewed
Jan 17, 2025
robert3005
requested changes
Jan 17, 2025
Contributor
robert3005
left a comment
robert3005
left a comment
There was a problem hiding this comment.
We should iterate validity imho
danking
force-pushed
the
dk/runend-stats
branch
from
f427d8d to
edc2bc2
Compare
Contributor
Author
|
Benchmark added. Indeed, iterating validity is faster. |
robert3005
reviewed
Jan 20, 2025
danking
force-pushed
the
dk/runend-stats
branch
from
e548506 to
e1bb680
Compare
robert3005
reviewed
Jan 21, 2025
robert3005
reviewed
Jan 21, 2025
robert3005
reviewed
Jan 21, 2025
robert3005
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.