chore[fuzz]: added decimal array ops#3571
Merged
joseph-isaacs merged 7 commits intodevelopfrom Jun 19, 2025
Merged
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Contributor
|
semver wise this isn't a feature - it doesn't really affect the public API |
joseph-isaacs
changed the title
joseph-isaacs
added
changelog/chore
Contributor
|
While you're here can you eliminate the fallthrough cases and enumerate them so when adding a new dtype you will have to at least acknowledge you're not implementing them. I completely missed this when reviewing decimaldtype prs |
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
robert3005
reviewed
Jun 19, 2025
Co-authored-by: Robert Kruszewski <github@robertk.io>
robert3005
approved these changes
Jun 19, 2025
mwlon
pushed a commit
to mwlon/vortex
that referenced
this pull request
Jul 4, 2025
Would be nice to be able to be generic over a `NativePType` and a `NativeDecimalType` --------- Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> Signed-off-by: mwlon <m.w.loncaric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be nice to be able to be generic over a
NativePTypeand aNativeDecimalType