Merged
Conversation
Signed-off-by: blaginin <dima@spiraldb.com>
Signed-off-by: blaginin <dima@spiraldb.com>
Contributor
joseph-isaacs
left a comment
joseph-isaacs
left a comment
There was a problem hiding this comment.
Later/now it might be nice to have a version of this that handles duplicates in a different way
vortex-dtype/src/struct_.rs
Outdated
| /// | ||
| /// # Errors | ||
| /// Returns an error if the merged struct would have duplicate field names. | ||
| pub fn merge(&self, other: &Self) -> VortexResult<Self> { |
Contributor
There was a problem hiding this comment.
shall we call this disjoint_merge?
Signed-off-by: blaginin <dima@spiraldb.com>
joseph-isaacs
approved these changes
Jun 20, 2025
mwlon
pushed a commit
to mwlon/vortex
that referenced
this pull request
Jul 4, 2025
Signed-off-by: mwlon <m.w.loncaric@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forth time I had to write this logic 😀 Maybe we can have it here?