duckdb: marshal query results via C API #3593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ax1
added
feature
Signed-off-by: Alexander Droste <[email protected]>
0ax1
force-pushed
the
ad/expand-ddb-connection-wrapper
branch
from
284b2e2 to
9da8a98
Compare
Contributor
|
Mind adding an description explaining the motivation of this change. |
Contributor
|
I wonder if this has much overhead compared to the arrow exporter, maybe marshalling can be done after timing the run? |
Contributor
Contributor
Benchmarks: TPC-H on NVMETable of Results
|
Contributor
Benchmarks: TPC-H on S3Table of Results
|
Contributor
Benchmarks: compressTable of Results
|
Contributor
Benchmarks: Clickbench on NVMETable of Results
|
Contributor
Author
Marshelling is opt-in where the extend of the marshelling is given by how E.g. in clickbench ddb2 we skip the marshelling: The result pointer of a query always gets assigned in If you look at
|
Contributor
|
This is a good find! It does however rely on another marshalling layer from duckdb to rust primitive think this can be unified with the vx conversion, maybe using vortex scalar or vx-scalar using this marshalling. |
…ection-wrapper Signed-off-by: Alexander Droste <[email protected]>
Signed-off-by: Alexander Droste <[email protected]>
joseph-isaacs
approved these changes
Jun 23, 2025
mwlon
pushed a commit
to mwlon/vortex
that referenced
this pull request
Jul 4, 2025
Replaces duckdb-rs query result handling with custom marshaling via DuckDB C API. This change removes the dependency on duckdb-rs and provides more fine-grained control over querying and result processing. Changes: - Add `QueryResult` wrapper for C API marshaling - Replace Connection::execute*() methods with query() returning `QueryResult` - Implement result extraction via `TryFrom` - Remove duckdb-rs fork dependency - Update tests to use new interface Signed-off-by: Alexander Droste <[email protected]> Signed-off-by: mwlon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces duckdb-rs query result handling with custom marshaling via DuckDB C API. This change removes the dependency on duckdb-rs and provides more fine-grained control over querying and result processing.
Changes:
QueryResultwrapper for C API marshalingQueryResultTryFrom