chore[vortex-expr]: move core expressions into their own module #3596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
added
chore
Contributor
|
I don't get what |
Contributor
Author
|
I want to put all the (core) expression definitions into their own crate. Not sure what a good name is. The current setup is a little confusing as to what is what. I want to make a distinction between expr trait & definitions and specific expression instances. |
joseph-isaacs
changed the title
Contributor
|
call it |
Signed-off-by: Joe Isaacs <[email protected]>
robert3005
approved these changes
Jun 23, 2025
mwlon
pushed a commit
to mwlon/vortex
that referenced
this pull request
Jul 4, 2025
…x-data#3596) do we want to call these core, or something else? Signed-off-by: Joe Isaacs <[email protected]> Signed-off-by: mwlon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do we want to call these core, or something else?