Skip to content

chore: Fix compilation of benchmarks if gpu_unstable is not enabled #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 1 commit into from
Nov 18, 2025
Merged

chore: Fix compilation of benchmarks if gpu_unstable is not enabled #5370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 16 additions & 25 deletions vortex-gpu/benches/gpu_bitunpack.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// SPDX-FileCopyrightText: Copyright the Vortex contributors

#![allow(clippy::unwrap_used)]
#![cfg(gpu_unstable)]
#![allow(dead_code)]

use std::sync::Arc;
use std::time::Duration;
Expand All @@ -17,9 +17,6 @@ use vortex_buffer::BufferMut;
use vortex_dtype::NativePType;
use vortex_error::VortexUnwrap;
use vortex_fastlanes::{BitPackedArray, FoRArray};
use vortex_gpu::{
create_run_jit_kernel, cuda_bit_unpack_timed, cuda_for_bp_unpack_timed, cuda_for_unpack_timed,
};

// Data sizes: 1GB, 2.5GB, 5GB, 10GB
// These are approximate sizes in bytes, accounting for bit-packing compression
Expand Down Expand Up @@ -91,6 +88,7 @@ fn make_alp_array(len: usize) -> ArrayRef {
.into_array()
}

#[cfg(gpu_unstable)]
fn benchmark_gpu_decompress_kernel_only(c: &mut Criterion) {
let mut group = c.benchmark_group("gpu_decompress_kernel_only");

Expand All @@ -112,7 +110,8 @@ fn benchmark_gpu_decompress_kernel_only(c: &mut Criterion) {
let mut total_time = Duration::ZERO;
for _ in 0..iters {
// This only measures kernel execution time, not memory transfers
let kernel_time_ns = cuda_bit_unpack_timed(array, Arc::clone(&ctx)).unwrap();
let kernel_time_ns =
vortex_gpu::cuda_bit_unpack_timed(array, Arc::clone(&ctx)).unwrap();
total_time += kernel_time_ns;
}
total_time
Expand All @@ -123,6 +122,7 @@ fn benchmark_gpu_decompress_kernel_only(c: &mut Criterion) {
group.finish();
}

#[cfg(gpu_unstable)]
fn benchmark_gpu_for_decompress_kernel_only(c: &mut Criterion) {
let mut group = c.benchmark_group("gpu_for_decompress_kernel_only");

Expand All @@ -143,7 +143,7 @@ fn benchmark_gpu_for_decompress_kernel_only(c: &mut Criterion) {
for _ in 0..iters {
// This only measures kernel execution time, not memory transfers
let (_result, kernel_time) =
cuda_for_unpack_timed(array, Arc::clone(&ctx)).unwrap();
vortex_gpu::cuda_for_unpack_timed(array, Arc::clone(&ctx)).unwrap();
total_time += kernel_time;
}
total_time
Expand All @@ -154,6 +154,7 @@ fn benchmark_gpu_for_decompress_kernel_only(c: &mut Criterion) {
group.finish();
}

#[cfg(gpu_unstable)]
fn benchmark_gpu_for_bp_fused_decompress_kernel_only(c: &mut Criterion) {
let mut group = c.benchmark_group("gpu_for_bp_fused_decompress_kernel_only");

Expand All @@ -174,7 +175,7 @@ fn benchmark_gpu_for_bp_fused_decompress_kernel_only(c: &mut Criterion) {
for _ in 0..iters {
// This only measures kernel execution time, not memory transfers
let (_result, kernel_time) =
cuda_for_bp_unpack_timed(array, Arc::clone(&ctx)).unwrap();
vortex_gpu::cuda_for_bp_unpack_timed(array, Arc::clone(&ctx)).unwrap();
total_time += kernel_time;
}
total_time
Expand All @@ -185,6 +186,7 @@ fn benchmark_gpu_for_bp_fused_decompress_kernel_only(c: &mut Criterion) {
group.finish();
}

#[cfg(gpu_unstable)]
fn benchmark_gpu_for_bp_jit_decompress_kernel_only(c: &mut Criterion) {
let mut group = c.benchmark_group("benchmark_gpu_for_bp_jit_decompress_kernel_only");

Expand All @@ -205,7 +207,8 @@ fn benchmark_gpu_for_bp_jit_decompress_kernel_only(c: &mut Criterion) {
let mut total_time = Duration::ZERO;
for _ in 0..iters {
// This only measures kernel execution time, not memory transfers
let (_result, kernel_time) = create_run_jit_kernel(&ctx, array).unwrap();
let (_result, kernel_time) =
vortex_gpu::create_run_jit_kernel(&ctx, array).unwrap();
total_time += kernel_time.elapsed().unwrap();
}
total_time
Expand All @@ -216,23 +219,7 @@ fn benchmark_gpu_for_bp_jit_decompress_kernel_only(c: &mut Criterion) {
group.finish();
}

#[allow(dead_code)]
fn benchmark_cpu_canonicalize(c: &mut Criterion) {
let mut group = c.benchmark_group("cpu_canonicalize");

for (len, label) in DATA_SIZES {
let len = len.next_multiple_of(1024);
let array = make_bitpackable_array::<u32>(len);

group.throughput(Throughput::Bytes((len * size_of::<u32>()) as u64));
group.bench_with_input(BenchmarkId::new("u32", label), &array, |b, array| {
b.iter(|| array.clone().into_array().to_canonical());
});
}

group.finish();
}

#[cfg(gpu_unstable)]
criterion_group!(
benches,
benchmark_gpu_decompress_kernel_only,
Expand All @@ -242,4 +229,8 @@ criterion_group!(
);

// criterion_group!(benches, benchmark_gpu_for_bp_jit_decompress_kernel_only);
#[cfg(gpu_unstable)]
criterion_main!(benches);

#[cfg(not(gpu_unstable))]
fn main() {}
Loading