Skip to content

Fix: bring back lance compression benchmark #5840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connortsui20 merged 1 commit into from
Dec 30, 2025
Merged

Fix: bring back lance compression benchmark #5840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion benchmarks/compress-bench/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ use ::vortex::array::arrays::ChunkedArray;
use ::vortex::array::arrays::recursive_list_from_list_view;
use arrow_array::RecordBatch;
use arrow_schema::Schema;

#[cfg(feature = "lance")]
pub use lance_bench::compress::LanceCompressor;
pub mod parquet;
pub mod vortex;

Expand Down
4 changes: 3 additions & 1 deletion benchmarks/compress-bench/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ use std::path::PathBuf;
use std::time::Duration;

use clap::Parser;
#[cfg(feature = "lance")]
use compress_bench::LanceCompressor;
use compress_bench::parquet::ParquetCompressor;
use compress_bench::vortex::VortexCompressor;
use indicatif::ProgressBar;
Expand Down Expand Up @@ -92,7 +94,7 @@ fn get_compressor(format: Format) -> Box<dyn Compressor> {
Format::OnDiskVortex => Box::new(VortexCompressor),
Format::Parquet => Box::new(ParquetCompressor::new()),
#[cfg(feature = "lance")]
Format::Lance => todo!(),
Format::Lance => Box::new(LanceCompressor),
_ => unimplemented!("Compress bench not implemented for {format}"),
}
}
Expand Down
Loading