Skip to content

Conversation

@asubiotto
Copy link
Contributor

@asubiotto asubiotto commented Jan 22, 2026

The code previously panicked because it assumed a non-empty sizes array.

Fixes #6047

@asubiotto asubiotto added the changelog/fix A bug fix label Jan 22, 2026
@gatesn gatesn enabled auto-merge (squash) January 22, 2026 15:11
@asubiotto asubiotto force-pushed the asubiotto/emptylist branch from 16b9806 to f415acf Compare January 22, 2026 15:11
@robert3005
Copy link
Contributor

Thanks for the fix, fuzzer also found it in #6047

@asubiotto asubiotto force-pushed the asubiotto/emptylist branch from f415acf to 481ff21 Compare January 22, 2026 15:13
The code previously cause an underflow because it assumed a non-empty sizes
array.

Signed-off-by: Alfonso Subiotto Marques <alfonso.subiotto@polarsignals.com>
@asubiotto asubiotto force-pushed the asubiotto/emptylist branch from 481ff21 to b011043 Compare January 22, 2026 15:14
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 22, 2026

Merging this PR will degrade performance by 16.58%

⚡ 7 improved benchmarks
❌ 2 regressed benchmarks
✅ 1245 untouched benchmarks
⏩ 1254 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation canonical_into_non_nullable[(10000, 100, 0.0)] 2.7 ms 1.9 ms +42.35%
Simulation canonical_into_non_nullable[(10000, 100, 0.1)] 4.5 ms 3.7 ms +22.18%
Simulation canonical_into_non_nullable[(10000, 100, 0.01)] 2.9 ms 2.1 ms +37.72%
Simulation canonical_into_nullable[(10000, 10, 0.0)] 444.1 µs 529.3 µs -16.09%
Simulation into_canonical_non_nullable[(10000, 100, 0.01)] 3 ms 2.2 ms +36.63%
Simulation canonical_into_nullable[(10000, 100, 0.0)] 4.1 ms 4.9 ms -16.58%
Simulation into_canonical_non_nullable[(10000, 100, 0.1)] 4.6 ms 3.8 ms +21.42%
Simulation into_canonical_non_nullable[(10000, 100, 0.0)] 2.7 ms 1.9 ms +41.72%
Simulation into_canonical_nullable[(10000, 100, 0.0)] 5.2 ms 4.4 ms +18.36%

Comparing asubiotto/emptylist (b011043) with develop (f37bc77)

Open in CodSpeed

Footnotes

  1. 1254 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn merged commit 7f229c6 into develop Jan 22, 2026
42 of 45 checks passed
@gatesn gatesn deleted the asubiotto/emptylist branch January 22, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fuzzing Crash: Integer overflow in list_view_zctl with empty sizes array

5 participants