Skip to content

fix: only link nvcomp for linux #6144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
0ax1 merged 1 commit into from
Jan 26, 2026
Merged

fix: only link nvcomp for linux #6144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions vortex-cuda/nvcomp/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,20 +109,6 @@ fn main() {
);
}

// Link against nvcomp dynamically.
println!("cargo:rustc-link-search=native={}", lib_dir.display());
println!("cargo:rustc-link-lib=dylib=nvcomp");
println!("cargo:rustc-link-arg=-Wl,-rpath,{}", lib_dir.display());

// Export the library path for downstream crates via the `links` manifest key.
// Downstream crates can access this via `env::var("DEP_NVCOMP_LIB_DIR")` in their
// build.rs and add their own rpath:
//
// if let Ok(nvcomp_lib) = env::var("DEP_NVCOMP_LIB_DIR") {
// println!("cargo:rustc-link-arg=-Wl,-rpath,{nvcomp_lib}");
// }
println!("cargo:lib_dir={}", lib_dir.display());

let bindings = bindgen::Builder::default()
.header(include_dir.join("nvcomp.h").to_string_lossy())
.header(include_dir.join("nvcomp/zstd.h").to_string_lossy())
Expand All @@ -142,6 +128,19 @@ fn main() {
// Set cuda_available cfg if CUDA is detected on the system.
// Gates tests and benchmarks that require CUDA at runtime.
if cuda_available() {
// Link against nvcomp dynamically.
println!("cargo:rustc-link-search=native={}", lib_dir.display());
println!("cargo:rustc-link-lib=dylib=nvcomp");
println!("cargo:rustc-link-arg=-Wl,-rpath,{}", lib_dir.display());

// Export the library path for downstream crates via the `links` manifest key.
// Downstream crates can access this via `env::var("DEP_NVCOMP_LIB_DIR")` in their
// build.rs and add their own rpath:
//
// if let Ok(nvcomp_lib) = env::var("DEP_NVCOMP_LIB_DIR") {
// println!("cargo:rustc-link-arg=-Wl,-rpath,{nvcomp_lib}");
// }
println!("cargo:lib_dir={}", lib_dir.display());
println!("cargo:rustc-cfg=cuda_available");
}
}
Expand Down
Loading