Support reading SparseArray with non zero offset#7150
Merged
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
gatesn
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated by #7094 I tried simplifying offset handling in Patches.
Unfortunately because of how chunk_offsets and indices interact with each other
you need to store two offsets in order to support zero-copy slicing.
Since we want to support zero copy slicing there's nothing fundamentally better
we can do here than supporting non zero offsets.
Signed-off-by: Robert Kruszewski github@robertk.io