Skip to content

Expose expressions for C API#7190

Open
myrrc wants to merge 1 commit intodevelopfrom
myrrc/expressions-ffi
Open

Expose expressions for C API#7190
myrrc wants to merge 1 commit intodevelopfrom
myrrc/expressions-ffi

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Mar 27, 2026

Expose a subset of expressions to test filtering in Scan API:
root, column, get_item, select, or, not, is_null, and binary operators, including shortcuts like eq.
Add vx_array_apply to test C-side expression application.

This patch does not include C++ FFI tests because we can't create vx_arrays' yet, #7148.
The next steps are exposing literal expressions and dynamic expressions.

@myrrc myrrc added the changelog/feature A new feature label Mar 27, 2026
@myrrc myrrc requested a review from 0ax1 March 27, 2026 15:46
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from f27c320 to ccff59e Compare March 27, 2026 15:50
@myrrc myrrc marked this pull request as ready for review March 27, 2026 15:50
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from ccff59e to 1bc107f Compare March 27, 2026 15:59
@myrrc myrrc enabled auto-merge (squash) March 27, 2026 16:05
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/expressions-ffi branch from 1bc107f to bc6ab5f Compare March 27, 2026 16:11
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 27, 2026

Merging this PR will degrade performance by 15.51%

❌ 2 regressed benchmarks
✅ 1104 untouched benchmarks
⏩ 1522 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[1024] 477.2 ns 535.6 ns -10.89%
Simulation bitwise_not_vortex_buffer_mut[128] 317.8 ns 376.1 ns -15.51%

Comparing myrrc/expressions-ffi (bc6ab5f) with develop (b524763)

Open in CodSpeed

Footnotes

  1. 1522 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant