-
Notifications
You must be signed in to change notification settings - Fork 0
ci/setup #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/setup #2
Changes from all commits
b64232c
1fce5bc
da6e322
9fc004a
781dc71
ce7a403
984b560
89413ce
46c2523
01afe8c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: Code Coverage | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| jobs: | ||
| call_reusable_workflow: | ||
| uses: vortexntnu/vortex-ci/.github/workflows/reusable-code-coverage.yml@main | ||
| secrets: | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| name: Industrial CI | ||
|
|
||
| on: | ||
| push: | ||
| workflow_dispatch: | ||
| schedule: | ||
| - cron: '0 1 * * *' # Runs daily | ||
|
|
||
| jobs: | ||
| call_reusable_workflow: | ||
| uses: vortexntnu/vortex-ci/.github/workflows/reusable-industrial-ci.yml@main | ||
| with: | ||
| ros_repo: '["main", "testing"]' |
This file was deleted.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unit test paths are not defined
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It seemed to work fine without needing to specify it, I think its only if the filestructure is a mess (like vortex-auv) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| coverage: | ||
| precision: 2 | ||
| round: down | ||
| status: | ||
| project: | ||
| default: | ||
| informational: true | ||
| flags: | ||
| - unittests | ||
| patch: off | ||
| fixes: | ||
| - "ros_ws/src/vortex_utils/::" | ||
| comment: | ||
| layout: "diff, flags, files" | ||
| behavior: default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deviates somewhat from the setup used in vortex-auv, in that it here runs on pull_request, and the job name being coverage_build as opposed to call_reusable_workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I checked on some other repositories and they have their code coverage to run on pull requests also, so I just copied that, but should update vortex-auv too. And should change name true true