Skip to content

Improve language identifying Legislature for states, cities & counties #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dallasjc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve language identifying Legislature for states, cities & counties #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions views/endorsement-page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ const rep = (r) => {
const legislature = (measure) => {
const notLocal = measure.legislature_name.length === 2 || measure.legislature_name === 'U.S. Congress'
const measureImage = notLocal ? `${ASSETS_URL}/legislature-images/${measure.legislature_name}.png` : `${ASSETS_URL}/legislature-images/local.png`
const name = measure.legislature_name.length === 2 ? stateNames[measure.legislature_name] : measure.legislature_name
const generalAssemblyStates = "'Alaska', 'Colorado', 'Connecticut', 'Delaware', 'Illinois', 'Iowa', 'Maryland', 'Mississippi', 'Ohio', 'Pennsylvania', ' Rhode Island', 'Tennessee', 'Virginia'"

return html`
<div class="column">
Expand All @@ -179,8 +179,14 @@ const legislature = (measure) => {
</div>
</div>
<div class="media-content has-text-weight-semibold is-size-5" style="line-height: 24px;">
${name}<br />
${measure.legislature_name === 'U.S. Congress' ? '' : 'Legislature'}
${measure.legislature_name}<br />
${measure.legislature_name === 'U.S. Congress' ? ''
: measure.legislature_name.includes('County') || measure.legislature_name.includes('San Francisco') ? 'Supervisors'
: measure.legislature_name.includes('Miami') ? 'Commission'
: measure.legislature_name.includes(',') ? 'Council' // other than SF & Miami all top 50 cities use some variation of Council
: generalAssemblyStates.includes(measure.legislature_name) ? 'General Assembly'
: measure.legislature_name === 'Massachusetts' || measure.legislature_name === 'New Hampshire' ? 'General Court'
: 'State Legislature'}
</div>
</div>
</div>
Expand Down