switch to viper's maintained mapstructure instead of mitchellh's#596
Closed
aladeeb wants to merge 2 commits intovouch:masterfrom
Closed
switch to viper's maintained mapstructure instead of mitchellh's#596aladeeb wants to merge 2 commits intovouch:masterfrom
aladeeb wants to merge 2 commits intovouch:masterfrom
Conversation
aladeeb
changed the title
Collaborator
|
Thanks for this, but I merged this one which was a smaller change: #598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a fix for a breaking change introduced in viper minor version bump up (v1.20). It was failing to build the package with the old mapstructure module. So, I've moved from using mitchellh's mapstructure as it's deprecated to the maintained one by go-viper.
This is according to v1.20 release notes: https://github.com/spf13/viper/blob/master/UPGRADE.md#breaking-githubcommitchellhmapstructure-depedency-replaced
I had to use
github.com/go-viper/mapstructure/v2instead ofgithub.com/mitchellh/mapstructure