Skip to content

Conversation

@revolunet
Copy link

@revolunet revolunet commented Jan 3, 2020

👋 Add support for options.author :

publisher.publish("log-YYMMAA", logContent, {
  message: 'some commit message',
  author: {
    name: 'Clint',
    email: '[email protected]'
  }
})

@revolunet
Copy link
Author

Hi @voxpelli, any chance this can be merged ?

@voxpelli
Copy link
Owner

Yes, absolutely, sorry for delay

@voxpelli
Copy link
Owner

I think I would prefer to not just forward the author option but to actually pick the specific properties from it and just forward those. Then the API of this module doesn’t become coupled with the API of GitHub and accidental submits of extra data becomes impossible (if eg. one adds an object which implements author fields but also lots of other fields)

@revolunet
Copy link
Author

Ok, i'm not sure ive understood correctly but heres a fix to only pick name and email

@revolunet
Copy link
Author

Bump 😁

Base automatically changed from master to main January 25, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants