Restore behavior of apply_manifest_on#100
Merged
jaevans merged 2 commits intovoxpupuli:masterfrom Jan 21, 2026
Merged
Conversation
…e result of the on method call.
bwitt
reviewed
Jan 21, 2026
Contributor
Author
|
Test added! |
silug
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return the previous behavior of apply_manifest_on method returning the result of the on method call.
The previous change was letting the value of
successfall out of the method instead of the result of on. On can "fail" while not raising an exception, and that is important to tests.