Drop support for nightly repos#57
Merged
bastelfreak merged 1 commit intovoxpupuli:masterfrom Mar 18, 2025
Merged
Conversation
This isn't working since months because Perforce doesn't publish them anymore, we never used it on our CI, and OpenVox doesn't have nightlies yet.
jstraw
approved these changes
Mar 18, 2025
ekohl
reviewed
Mar 18, 2025
| nightly: {}, | ||
| }, | ||
| puppet: { | ||
| release: { |
Member
There was a problem hiding this comment.
Should we remove this layer and simplify it?
| def self.install_puppet_release_repo_on(host, collection = 'puppet') | ||
| requirement_name = collection.gsub(/\d+/, '') | ||
| repos = REPOS[requirement_name.to_sym][nightly ? :nightly : :release] | ||
| repos = REPOS[requirement_name.to_sym][:release] |
Member
There was a problem hiding this comment.
Main argument for removing the release layer is that it doesn't add anything and if requirement_name.to_sym isn't found, it ends up being nil[:release] which crashes.
I didn't spot this in the previous PR, but a safer alternative (if you want to keep the :release layer)
Suggested change
| repos = REPOS[requirement_name.to_sym][:release] | |
| repos = REPOS.dig(requirement_name.to_sym, :release) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't working since months because Perforce doesn't publish them anymore, we never used it on our CI, and OpenVox doesn't have nightlies yet.
As a followup for #56 , this drop support for nightlies.