-
Notifications
You must be signed in to change notification settings - Fork 78
update : EOL OSes and the update script #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
64e1766 to
09d5e2c
Compare
|
@Tonguechaude thanks for the PR, can you please sign your commit with a GPG or SSH key? |
3e02615 to
a489e09
Compare
a489e09 to
861a817
Compare
|
This is great! would love to see this merged! Aside from the merge conflicts, what needs to happen to get this approved and merged? |
|
I was pointed at https://github.com/voxpupuli/puppet_metadata, which can abstract this a bit more; is that something to consider here? |
|
voxpupuli/puppet_metadata@2f103e0 already added a command to add missing OS versions and one to list the EOL ones. It hasn't been released yet, but it'd be great if people can give it a spin to see if it works for them |
|
Why dont we change that to remove EOL OSes and then use it here? |
|
That is the long term goal, yes. Are you interested in providing a patch for puppet_metadata? |
|
whoops sorry for the mismention (I can't remove it?); yes I can probably work on this, but we should probably decide on naming for these OS-related commands |
|
I've created voxpupuli/puppet_metadata#204 to address |



refers to issue #973