Skip to content

Conversation

@Tonguechaude
Copy link

refers to issue #973

@Tonguechaude
Copy link
Author

Before :

image

After :

image image

@bastelfreak
Copy link
Member

@Tonguechaude thanks for the PR, can you please sign your commit with a GPG or SSH key?

@Tonguechaude Tonguechaude force-pushed the update_EOL_OSes branch 3 times, most recently from 3e02615 to a489e09 Compare July 16, 2025 11:17
@bwitt
Copy link
Contributor

bwitt commented Nov 14, 2025

This is great! would love to see this merged! Aside from the merge conflicts, what needs to happen to get this approved and merged?

@bwitt
Copy link
Contributor

bwitt commented Nov 14, 2025

I was pointed at https://github.com/voxpupuli/puppet_metadata, which can abstract this a bit more; is that something to consider here?

@ekohl
Copy link
Member

ekohl commented Nov 14, 2025

voxpupuli/puppet_metadata@2f103e0 already added a command to add missing OS versions and one to list the EOL ones. It hasn't been released yet, but it'd be great if people can give it a spin to see if it works for them

@bwitt
Copy link
Contributor

bwitt commented Nov 15, 2025

Why dont we change that to remove EOL OSes and then use it here?

@bastelfreak
Copy link
Member

That is the long term goal, yes. Are you interested in providing a patch for puppet_metadata?

@bwitt
Copy link
Contributor

bwitt commented Nov 15, 2025

whoops sorry for the mismention (I can't remove it?); yes I can probably work on this, but we should probably decide on naming for these OS-related commands

@bwitt
Copy link
Contributor

bwitt commented Nov 22, 2025

I've created voxpupuli/puppet_metadata#204 to address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants