Draft
Conversation
smortex
force-pushed
the
drop-legacy-maxconcurjobs
branch
from
8e6b4b3 to
c401e74
Compare
smortex
added
the
backwards-incompatible
bastelfreak
approved these changes
Jan 4, 2026
This fix a bunch of deprecation warnings.
When data types where added in version 5.4.0 a few years ago (#117), backward compatibility with old catalog that used String for all parameters was preserved. We already did a few major releases so keeping this backward compatibility does not make sense and we can make the types more consistent by removing them.
This parameter has been replaced by a max_concurrent_jobs for consistency with other classes.
smortex
force-pushed
the
drop-legacy-maxconcurjobs
branch
from
c401e74 to
f1d4976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #235, we fixed an incorrect behaviour of the
maxconcurjobsparameter of the storage configuration, and aligned it with the other bacula components by calling itmax_concurrent_jobs.Backward compatibility was kept, and a deprecation warning was added.
This PR drop these.
It is intended to be merged in the next major release of the module following a release including #235.