Replace none US-ASCII chars which can lead to encoding issues with puppet server

Author: project0

README.md

@@ -129,15 +129,15 @@ It is not intended to be used directly by external resources like node definitio
 
 #### Client - Class ::bareos::client::client
 
-The Client Resource (or FileDaemon) resource defines the name of the Client (as used by the Director) as well as the port on which the Client listens for Director connections.
+The Client Resource (or FileDaemon) resource defines the name of the Client (as used by the Director) as well as the port on which the Client listens for Director connections.
 
 #### Director - Define ::bareos::client::director
 
-The Director resource defines the name and password of the Directors that are permitted to contact this Client.
+The Director resource defines the name and password of the Directors that are permitted to contact this Client.
 
 #### Messages - Define ::bareos::client::messages
 
-The Messages resource defines how messages are to be handled and destinations to which they should be sent.
+The Messages resource defines how messages are to be handled and destinations to which they should be sent.
 
 ### Console
 `Class ::bareos::console`
@@ -156,8 +156,8 @@ If someone has more information, feel free to add this info ;-).
 
 #### Director - Define ::bareos::console::director
 
-The Director resource defines the attributes of the Director running on the network.
-You may have multiple Director resource specifications in a single Console configuration file.
+The Director resource defines the attributes of the Director running on the network.
+You may have multiple Director resource specifications in a single Console configuration file.
 If you have more than one, you will be prompted to choose one when you start the Console program.
 
 ```puppet
@@ -179,19 +179,19 @@ It is not intended to be used directly by external resources like node definitio
 
 #### Director - Class ::bareos::director::director
 
-To define the Director’s name and its access password used for authenticating the Console program.
-Only a single Director resource definition may appear in the Director’s configuration file.
+To define the Director's name and its access password used for authenticating the Console program.
+Only a single Director resource definition may appear in the Director's configuration file.
 
 #### Catalog - Define ::bareos::director::catalog
 
-To define in what database to keep the list of files and the Volume names where they are backed up.
+To define in what database to keep the list of files and the Volume names where they are backed up.
 Most people only use a single catalog.
 It is possible, however not adviced and not supported to use multiple catalogs.
 
 #### Client - Define ::bareos::director::client
 
-To define what Client is to be backed up.
-You will generally have multiple Client definitions.
+To define what Client is to be backed up.
+You will generally have multiple Client definitions.
 Each Job will reference only a single client.
 
 #### Console - Define ::bareos::director::console
@@ -201,11 +201,11 @@ Both the names and the passwords in these two entries must match much as is the
 
 #### Counter - Define ::bareos::director::counter
 
-The Counter Resource defines a counter variable that can be accessed by variable expansion used for creating Volume labels with the Label Format Dir Pool directive.
+The Counter Resource defines a counter variable that can be accessed by variable expansion used for creating Volume labels with the Label Format Dir Pool directive.
 
 #### FileSet - Define ::bareos::director::fileset
 
-To define the set of files to be backed up for each Client.
+To define the set of files to be backed up for each Client.
 You may have any number of FileSets but each Job will reference only one.
 
 FileSets do use `Include Exclude Items`, which are represented by hash. Hash values are only allowed to have other hashes, string values or array of string values.
@@ -226,8 +226,8 @@ FileSets do use `Include Exclude Items`, which are represented by hash. Hash val
 ```
 
 #### Job - Define ::bareos::director::job
-To define the backup/restore Jobs and to tie together the Client, FileSet and Schedule resources to be used for each Job.
-Normally, you will Jobs of different names corresponding to each client (i.e. one Job per client, but a different one with a different name for each client).
+To define the backup/restore Jobs and to tie together the Client, FileSet and Schedule resources to be used for each Job.
+Normally, you will Jobs of different names corresponding to each client (i.e. one Job per client, but a different one with a different name for each client).
 
 Jobs does have `Run Script`, which is represented by hash. Hash values are only allowed to have other hashes, string values or array of string values (like the Include Exclude Items in Fileset).
 
@@ -259,20 +259,20 @@ Almost the same like `Job`.
 
 #### Messages - Define ::bareos::director::messages
 
-To define where error and information messages are to be sent or logged.
-You may define multiple different message resources and hence direct particular classes of messages to different users or locations (files, ...).
+To define where error and information messages are to be sent or logged.
+You may define multiple different message resources and hence direct particular classes of messages to different users or locations (files, ...).
 
 #### Pool - Define ::bareos::director::pool
 
-To define the pool of Volumes that can be used for a particular Job.
+To define the pool of Volumes that can be used for a particular Job.
 Most people use a single default Pool.
 However, if you have a large number of clients or volumes, you may want to have multiple Pools.
 Pools allow you to restrict a Job (or a Client) to use only a particular set of Volumes.
 
 #### Profile - Define ::bareos::director::profile
 
-The Profile Resource defines a set of ACLs.
-Console Resources can be tight to one or more profiles, making it easier to use a common set of ACLs.
+The Profile Resource defines a set of ACLs.
+Console Resources can be tight to one or more profiles, making it easier to use a common set of ACLs.
 
 
 #### Schedule - Define ::bareos::director::schedule
@@ -284,8 +284,8 @@ In general, you specify an action to be taken and when.
 
 #### Storage - Define ::bareos::director::storage
 
-To define on what physical device the Volumes should be mounted.
-You may have one or more Storage definitions.
+To define on what physical device the Volumes should be mounted.
+You may have one or more Storage definitions.
 
 ### Monitor
 `Class ::bareos::monitor`
@@ -297,18 +297,18 @@ This class will be automatically included when a resource is defined.
 It is not intended to be used directly by external resources like node definitions or other modules.
 
 #### Client - Define ::bareos::monitor::client
-The Client resource defines the attributes of the Clients that are monitored by this Monitor.
+The Client resource defines the attributes of the Clients that are monitored by this Monitor.
 
 #### Director - Define ::bareos::monitor::director
-The Director resource defines the attributes of the Directors that are monitored by this Monitor.
+The Director resource defines the attributes of the Directors that are monitored by this Monitor.
 
 #### Monitor - Define ::bareos::monitor::monitor
-The Monitor resource defines the attributes of the Monitor running on the network.
-The parameters you define here must be configured as a Director resource
-in Clients and Storages configuration files, and as a Console resource in Directors configuration files.
+The Monitor resource defines the attributes of the Monitor running on the network.
+The parameters you define here must be configured as a Director resource
+in Clients and Storages configuration files, and as a Console resource in Directors configuration files.
 
 #### Storage - Define ::bareos::monitor::storage
-The Storage resource defines the attributes of the Storages that are monitored by this Monitor.
+The Storage resource defines the attributes of the Storages that are monitored by this Monitor.
 
 ### Storage
 `Class ::bareos::storage`
@@ -321,35 +321,35 @@ It is not intended to be used directly by external resources like node definitio
 
 #### Storage - Class ::bareos::storage::storage
 
-In general, the properties specified under the Storage resource define global properties of the Storage daemon.
+In general, the properties specified under the Storage resource define global properties of the Storage daemon.
 
 #### Autochange - Define ::bareos::storage::autochanger
 
 The Autochanger resource supports single or multiple drive autochangers
 by grouping one or more Device resources into one unit called an autochanger in Bareos
-(often referred to as a ”tape library” by autochanger manufacturers).
+(often referred to as a "tape library" by autochanger manufacturers).
 
 #### Device - Define ::bareos::storage::device
 
-The Device Resource specifies the details of each device (normally a tape drive) that can be used by the Storage daemon.
+The Device Resource specifies the details of each device (normally a tape drive) that can be used by the Storage daemon.
 There may be multiple Device resources for a single Storage daemon.
-In general, the properties specified within the Device resource are specific to the Device.
+In general, the properties specified within the Device resource are specific to the Device.
 
 #### Director - Define ::bareos::storage::director
 
-The Director resource specifies the Name of the Director which is permitted to use the services of the Storage daemon.
+The Director resource specifies the Name of the Director which is permitted to use the services of the Storage daemon.
 There may be multiple Director resources.
-The Director Name and Password must match the corresponding values in the Director’s configuration file.
+The Director Name and Password must match the corresponding values in the Director's configuration file.
 
 #### Messages - Define ::bareos::storage::messages
 
-The Messages resource defines how messages are to be handled and destinations to which they should be sent.
+The Messages resource defines how messages are to be handled and destinations to which they should be sent.
 
 #### NDMP - Define ::bareos::storage::ndmp
 
-The NDMP Resource specifies the authentication details of each NDMP client.
+The NDMP Resource specifies the authentication details of each NDMP client.
 There may be multiple NDMP resources for a single Storage daemon.
-In general, the properties specified within the NDMP resource are specific to one client.
+In general, the properties specified within the NDMP resource are specific to one client.
 
 ### WebUI
 `Class ::bareos::webui`

Rakefile

@@ -46,6 +46,8 @@ desc 'Validate manifests, templates, and ruby files'
 task :validate do
   Dir['manifests/**/*.pp'].each do |manifest|
     sh "puppet parser validate --noop #{manifest}"
+    # check if none us ascii chars exists
+    sh "tr -d \\\\000-\\\\177 < #{manifest} | wc -c | grep -q 0"
   end
   Dir['spec/**/*.rb', 'lib/**/*.rb'].each do |ruby_file|
     sh "ruby -c #{ruby_file}" unless ruby_file =~ %r{spec/fixtures}

manifests/client/client.pp

@@ -1,5 +1,5 @@
 # == Class: bareos::client::client
-# The Client Resource (or FileDaemon) resource defines the name of the Client (as used by the Director)
+# The Client Resource (or FileDaemon) resource defines the name of the Client (as used by the Director)
 # as well as the port on which the Client listens for Director connections.
 #
 # == Parameters

manifests/client/director.pp

@@ -1,5 +1,5 @@
 # == Define: bareos::client::director
-# The Director resource defines the name and password of the Directors that are permitted to contact this Client.
+# The Director resource defines the name and password of the Directors that are permitted to contact this Client.
 #
 # == Parameters
 # [*ensure*]

manifests/client/messages.pp

@@ -1,5 +1,5 @@
 # == Define: bareos::client::messages
-# The Messages resource defines how messages are to be handled and destinations to which they should be sent.
+# The Messages resource defines how messages are to be handled and destinations to which they should be sent.
 #
 # == Parameters
 # [*ensure*]

manifests/console/director.pp

@@ -1,6 +1,6 @@
 # == Define: bareos:console::director
-# The Director resource defines the attributes of the Director running on the network.
-# You may have multiple Director resource specifications in a single Console configuration file.
+# The Director resource defines the attributes of the Director running on the network.
+# You may have multiple Director resource specifications in a single Console configuration file.
 # If you have more than one, you will be prompted to choose one when you start the Console program.
 #
 # == Parameters

manifests/director/catalog.pp

@@ -1,5 +1,5 @@
 # == Define: bareos::director::catalog
-# To define in what database to keep the list of files and the Volume names where they are backed up.
+# To define in what database to keep the list of files and the Volume names where they are backed up.
 # Most people only use a single catalog.
 # It is possible, however not adviced and not supported to use multiple catalogs.
 #

manifests/director/client.pp

@@ -1,6 +1,6 @@
 # == Define: bareos::director::client
-# To define what Client is to be backed up.
-# You will generally have multiple Client definitions.
+# To define what Client is to be backed up.
+# You will generally have multiple Client definitions.
 # Each Job will reference only a single client.
 #
 # == Parameters

manifests/director/counter.pp

@@ -1,5 +1,5 @@
 # == Define: bareos::director::counter
-# The Counter Resource defines a counter variable that can be accessed by variable expansion used
+# The Counter Resource defines a counter variable that can be accessed by variable expansion used
 # for creating Volume labels with the Label Format Dir Pool directive.
 #
 # == Parameters

manifests/director/director.pp

@@ -1,6 +1,6 @@
 # == Class: bareos::director::director
-# To define the Director’s name and its access password used for authenticating the Console program.
-# Only a single Director resource definition may appear in the Director’s configuration file.
+# To define the Director's name and its access password used for authenticating the Console program.
+# Only a single Director resource definition may appear in the Director's configuration file.
 #
 # == Parameters
 # [*ensure*]