Skip to content

Add Ruby 3.4 support #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bastelfreak merged 2 commits into from
Jan 20, 2025
Merged

Add Ruby 3.4 support #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e57db9
Add Ruby 3.4 support
bastelfreak Jan 20, 2025
f23f1cd
fix tests
bastelfreak Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ jobs:
if: github.repository_owner == 'voxpupuli'
steps:
- uses: actions/checkout@v4
- name: Install Ruby 3.3
- name: Install Ruby 3.4
uses: ruby/setup-ruby@v1
with:
ruby-version: '3.3'
ruby-version: '3.4'
env:
BUNDLE_WITHOUT: release
- name: Build gem
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Install Ruby ${{ matrix.ruby }}
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3"
ruby-version: "3.4"
bundler-cache: true
- name: Run Rubocop
run: bundle exec rake rubocop
Expand All @@ -34,6 +34,7 @@ jobs:
- ruby: "3.2"
coverage: "yes"
- ruby: "3.3"
- ruby: "3.4"
env:
COVERAGE: ${{ matrix.coverage }}
name: RSpec - Ruby ${{ matrix.ruby }}
Expand Down
12 changes: 3 additions & 9 deletions features/git.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,7 @@ Feature: git
{
"name": "maestrodev-test",
"version": "1.0.2",
"dependencies": [

]
"dependencies": []
}
"""
When I run `git tag`
Expand Down Expand Up @@ -67,9 +65,7 @@ Feature: git
{
"name": "maestrodev-test",
"version": "1.0.2",
"dependencies": [

]
"dependencies": []
}
"""
When I run `git tag`
Expand Down Expand Up @@ -108,9 +104,7 @@ Feature: git
{
"name": "maestrodev-test",
"version": "1.0.2",
"dependencies": [

]
"dependencies": []
}
"""
When I run `git tag`
Expand Down
1 change: 1 addition & 0 deletions puppet-blacksmith.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Gem::Specification.new do |s|

s.required_ruby_version = '>= 2.7.0'

s.add_runtime_dependency 'base64', '~> 0.2.0'
s.add_runtime_dependency 'puppet-modulebuilder', '~> 2.0', '>= 2.0.2'
s.add_runtime_dependency 'rest-client', '~>2.0'
s.add_development_dependency 'aruba', '~> 2.1'
Expand Down