remove unused puppet testing dependency#141
Merged
bastelfreak merged 1 commit intovoxpupuli:masterfrom Jul 18, 2025
Merged
Conversation
bastelfreak
changed the title
kenyon
approved these changes
Jul 18, 2025
All tests pass fine without it
Member
|
We used to pull in puppetlabs_spec_helper and that required Puppet. I think it was because of that, but I'm just guessing based on reading my 8 year old PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All tests pass fine without it. @ekohl I didn't dig further down, maybe you remember why you moved puppet from a dependency to a dev dependency in #45. But I think it's safe to drop it now for real.