Add support for my use cases

[kBite]

1. some "idempotent" (non user-visible) changes

   • make parameters and headers more readable
     • it's opinionated, but pretty much inline with what other modules do
   • refactor defined type rule moving boilerplate to new function
   • simplify rule with some new data types

2. add support for my use cases

   • add parameters outerface, daddr_type, saddr_type, and ctstate

Of course, everything comes with tests and documentation. I didn't add tests for the function though, because I'd consider it tested indirectly as part of tests done on rule.

EDIT: Tests are failing due to outdated REFERENCE.md. Can't find redcarpet right now. Tried ...

$ bundle exec gem install redcarpet
Fetching redcarpet-3.6.0.gem
Building native extensions. This could take a while...
Successfully installed redcarpet-3.6.0
1 gem installed

$ gem install --user redcarpet
Building native extensions. This could take a while...
Successfully installed redcarpet-3.6.0
Parsing documentation for redcarpet-3.6.0
Done installing documentation for redcarpet after 0 seconds
1 gem installed

$ gem install redcarpet
Building native extensions. This could take a while...
Successfully installed redcarpet-3.6.0
Parsing documentation for redcarpet-3.6.0
Done installing documentation for redcarpet after 0 seconds
1 gem installed

... but still:

$ bundle exec rake strings:generate
[error]: Missing 'redcarpet' gem for Markdown formatting. Install it with `gem install redcarpet`

Will dig deeper tomorrow.

[smortex]

REFERENCE.md is outdated

Please update REFERENCE.md with

$ bundle exec rake strings:generate:reference

Add it to the PR and CI should continue.

[kBite]

@bastelfreak rebased against master

Regenerating README.md doesn't work for me:

(add-support-for-my-use-cases=) $ bundle exec rake strings:generate:reference
Could not find gem 'voxpupuli-test (~> 9.0)' in any of the gem sources listed in your Gemfile.
Run `bundle install` to install missing gems.

bundle fails to find ruby

(add-support-for-my-use-cases=) $ bundle install --path .vendor/ --without system_tests --without development --without release
Fetching gem metadata from https://rubygems.org/.......
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "ruby":
  In Gemfile:
    ruby

    puppet (>= 7.24, < 9) was resolved to 7.34.0, which depends on
      facter (> 2.0.1, < 5) was resolved to 4.10.0, which depends on
        ruby (>= 2.5, < 4.0)

    overcommit (>= 0.39.1) was resolved to 0.67.0, which depends on
      ruby (>= 2.6)

    puppet (>= 7.24, < 9) was resolved to 7.34.0, which depends on
      ruby (>= 2.5.0)

    voxpupuli-test (~> 9.0) was resolved to 9.2.0, which depends on
      ruby (>= 2.7.0)

Seems like the common demoninator is Ruby 2.6.0

(add-support-for-my-use-cases=) $ tree .vendor/
.vendor/
└── ruby
    └── 2.6.0

3 directories, 0 files