Skip to content

Conversation

@mdurell
Copy link

@mdurell mdurell commented Dec 28, 2017

Resolves upstream issue #147

Resolves upstream issue #147
@ekohl
Copy link
Member

ekohl commented Jan 2, 2018

Looks like we need to modulesync this to get the builds working.

@alexjfisher
Copy link
Member

I vaguely remember looking at something similar before.
Is the discussion here #120 (comment) relevant to this PR?

@mdurell
Copy link
Author

mdurell commented Jan 2, 2018

It does look like the changes in #120 happens to fix the sorting issue. I am testing this in a bit.

@mdurell
Copy link
Author

mdurell commented Jan 4, 2018

I'm testing and I do believe this will fix the problem but... It also causes other issues because of the renaming/restructuring of facts. This PR is a major (and a positive) change and while it does fix my issue and is still outstanding I am in favor of whatever solution is quickest to deliver to master in order to fix the brick sorting bug that is currently there.

Please respond and let me know when and what fix I can expect so I can decide if I need to run a local fork with a fix in place.

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Mar 26, 2018
@vox-pupuli-tasks
Copy link

Dear @mdurell, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@vox-pupuli-tasks
Copy link

Dear @mdurell, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@mdurell mdurell closed this by deleting the head repository Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants