Add xml header to the proxy template#1083
Open
marek130 wants to merge 1 commit intovoxpupuli:masterfrom
Open
Conversation
Fixing problem of restarting Jenkins service which caused adding this header.
ekohl
reviewed
Apr 29, 2024
Member
ekohl
left a comment
There was a problem hiding this comment.
Looking at the diff, it still wouldn't be idempotent since there is no line ending in the generated version while this template does. I wonder what the best way to achieve that is, because many tools actually try hard to ensure that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing problem of xml header. Restarting Jenkins service is adding this header.
Pull Request (PR) description
There is no possible to achieve the desired state by Puppet because the content of proxy.xml file is missing the XML header.
After restarting the Jenkins service the header is added automatically. So, there is a fight between the proxy template and Jenkins service.