Conversation
|
Hi @bastelfreak, since I am preparing the 5.2.0 release, does it make sense to merge some of the opened PR? |
|
|
None of the linked PRs have passing CI. This needs to be fixed before we continue. I currently don't have tue capacity to work on them. If you want, you can. pick those up, fix CI and resubmit them as new PRs. |
|
I see. I don't mind doing the work, but my knowledge about this is close to zero (and most of the CI logs have expired and are no longer available.) If there is something easy I can start with please let me know. About modulesync, actually for release I am preparing I rebased from your #394 because I couldn't wrap my head around the instructions in https://voxpupuli.org/docs/releasing_version/ The docs say "Run modulesync to ensure the dotfiles are up-to-date." but it does not explain how. Thanks |
SimonHoenscheid
left a comment
There was a problem hiding this comment.
Technically LGTM, lets get this pipeline green
|
@bastelfreak with #414 this i obsolete. Is it ok to just close and delete the branch? |
e436f6c to
35fb357
Compare
|
This isn't obsolete. The metadata.json currently doesn't list Puppet 8. |
No description provided.