(#396) Add support for adding hooks after cert creation#405
Merged
bastelfreak merged 1 commit intovoxpupuli:masterfrom Feb 10, 2026
Merged
(#396) Add support for adding hooks after cert creation#405bastelfreak merged 1 commit intovoxpupuli:masterfrom
bastelfreak merged 1 commit intovoxpupuli:masterfrom
Conversation
Member
Author
|
based on the code one could assume that this was already supported, so I labeled it as bug and not enhancement. |
bastelfreak
force-pushed
the
cleanup
branch
2 times, most recently
from
a4acbc8 to
8b3fc3e
Compare
certbot supports different hooks. They are executed during the certificate renewal. Those hooks are configured per-certificate. Previously you had to specify all hooks during the initial certificate creation. If a hook was added afterwards in Puppet, it was written to disk as a shell script, but it wasn't added to the configuration file. The config file wasn't managed with openvox at all, it was created by certbot. certbot has no cli options to update an existing config file. Because of that, we added an ini_setting resource to ensure that all hooks are added to the config file. Fixes voxpupuli#396
Sharpie
approved these changes
Feb 10, 2026
Sharpie
left a comment
Sharpie
left a comment
There was a problem hiding this comment.
Looks good to me. Moves some variable definitions earlier in the manifest, adds an ini_setting, and adds test cases 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
certbot supports different hooks. They are executed during the certificate renewal. Those hooks are configured per-certificate. Previously you had to specify all hooks during the initial certificate creation. If a hook was added afterwards in Puppet, it was written to disk as a shell script, but it wasn't added to the configuration file. The config file wasn't managed with openvox at all, it was created by certbot. certbot has no cli options to update an existing config file. Because of that, we added an ini_setting resource to ensure that all hooks are added to the config file.
Fixes #396