Closes #388#389
Open
danwiltshire wants to merge 1 commit intovoxpupuli:masterfrom
danwiltshire:pipelines
Open
Conversation
renamed class to pipeline_config using array removed underscore from pipelineconfig class name renamed pipelineconfig to pipeline_files for readability renamed pipelineconfig.pp to pipeline_files.pp changed dynamic values to static for testing require the configfile removed dollar symbols sourced from removed parameters from class changed from test content to array content converted id value back to test value converted pipeline_files to Hash added test notify converted to dynamic hash content added pretty JSON converter added pretty JSON converter with output changed to notify changed to notify with brackets removed pretty JSON converter added .each for removed notify added examples added usage section for pipeline_files fixed linting issues wrote test cases for pipeline-files
|
Dear @danwiltshire, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrote a wrapper class to call the configfile defined type. Spec tests have also been written for the new functionality. README.md updated with usage examples.
Rspec tests complete successfully and Beaker tests complete successfully on nodesets CentOS 6+7. The Beaker tests do not start to run on the other nodesets with errors such as: "Couldn't find id: {"stream":"Step 1/18 : FROM library/ubuntu:16.04"}"