Skip to content

Windows can't handle the : character in a filename. #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Windows can't handle the : character in a filename. #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,7 @@ Puppetfile.lock
.*.sw?
.yardoc/
Guardfile

# This filename makes windows barf. Which breaks deploys
spec/fixtures/provider/network_config/redhat_spec/network-scripts/ifcfg-eth0:10000000

10 changes: 10 additions & 0 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,16 @@ task 'lint:auto_correct' do
Rake::Task[:lint_fix].invoke
end

# So windows cannot handle paths with a : character. But that's used by
# a network config fixture. The simplest way to handle it without weird
# and confusing File.read mocks is to simply symlink it before tests are
# run. Gross? Yeah, but it seems like the least gross option.
task :fix_pathname do
FileUtils.ln_sf 'spec/fixtures/provider/network_config/redhat_spec/network-scripts/ifcfg-eth0_10000000',
'spec/fixtures/provider/network_config/redhat_spec/network-scripts/ifcfg-eth0:10000000'
end
task :spec_prep => :fix_pathname

desc 'Run acceptance tests'
RSpec::Core::RakeTask.new(:acceptance) do |t|
t.pattern = 'spec/acceptance'
Expand Down
9 changes: 0 additions & 9 deletions spec/fixtures/provider/network_config/redhat_spec/network-scripts/ifcfg-eth0:10000000
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions spec/fixtures/provider/network_config/redhat_spec/network-scripts/ifcfg-eth0_10000000
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
spec/fixtures/provider/network_config/redhat_spec/network-scripts/ifcfg-eth0_10000000