streamline defaults with nginx

[Enrice]

Pull Request (PR) description

All parameters with feasible defaults in nginx itself become Optional.
Also fixes some minor type isssues.

This Pull Request (PR) fixes the following issues

Fixes #1660

[kenyon]

Where you're making changes to every parameter, maybe also stop aligning the equals signs (just have one space of separation, like Integer $abc = 0,) so that we don't have so many diffs due to alignment changes later.

[Enrice]

Do you mean only simple assignments or also parameter defaults?

For my understanding see latest commit.

[kenyon]

Do you mean only simple assignments or also parameter defaults?

For my understanding see latest commit.

For all class parameter lists, I think we shouldn't be aligning the equals signs. It just causes too many diffs when there are changes to the parameter lists.

[Enrice]

puppet style guide says otherwise:
https://help.puppet.com/core//8/Content/PuppetCore/style_guide_classes.htm#Parameterindentationandalignment

(You should however not take the examples too serious as they are displayed, there seems to be a HTML issue. So inspect the HTML source instead...)

That taken into account the current state of the PR should be ok...

[kenyon]

That part of the style guide I don't think we should follow, especially for a module like this with large lists of parameters. See also voxpupuli/voxpupuli.github.io#322

[Enrice]

ok, then everything should be fine now.

[kenyon]

Minor thing, but not sure it's valuable to have nginx defaults in the comments, since the defaults can change.

[bastelfreak]

@Enrice could you please submit the different changes as individual PRs? That's probably easier than a big rebase, and it gives us a better changelog.

[sebastianrakel]

in favor of #1690 and #1692 we will close this issue, it's separates the whitespace change and streamline default changes in two PRs for better readability