Fix PBKDF2 implementation to use Adapted Base64 encoding#474
Merged
smortex merged 1 commit intovoxpupuli:masterfrom Jan 22, 2026
Merged
Fix PBKDF2 implementation to use Adapted Base64 encoding#474smortex merged 1 commit intovoxpupuli:masterfrom
smortex merged 1 commit intovoxpupuli:masterfrom
Conversation
smortex
approved these changes
Jan 22, 2026
Member
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
"Adapted Base64" 🤡
Yayyyy! XKCD 927 hit one again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In #472, I implemented PBKDF2 support using standard Base64 encoding. However, the OpenLDAP PBKDF2 module documentation (https://git.openldap.org/openldap/openldap/-/blob/master/contrib/slapd-modules/passwd/pbkdf2/README?ref_type=heads) specifies the use of Adapted Base64 (AB64) encoding.
My initial implementation was therefore non-functional. I missed this issue due to an error in my testing protocol.
This fix has been tested and validated against OpenLDAP 2.6.10 with Puppet Server 7.17.3.
My apologies for the initial oversight.