(doc) Add and test for current REFERENCE.md using puppet-strings #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpartlow
force-pushed
the
add-package-parameter-to-install
branch
3 times, most recently
from
4fb8f6e to
e3f533f
Compare
Adds a REFERENCE.md generated with puppet-strings, and minimal changes needs to validate in the main pr_testing workflow that a given pr's REFERENCE.md is up to date with the state of the module.
as a dependency for puppet-strings. OpenVoxProject/planning#45 (comment)
jpartlow
force-pushed
the
add-package-parameter-to-install
branch
2 times, most recently
from
52841d5 to
a6f613b
Compare
By default, openvox_bootstrap::install will still install openvox-agent, but you can override `package` to install another package, such as openvox-server or openvoxdb from the collection.
...by prefixing the os related globals with 'os_'. Also changes set_platform() to set_platform_globals() and has it set os_family as well. Makes setting of the platform global variables little more linear, and simplifies a bit of the defensive set global calls in the common.sh.
...and into the common.sh.
jpartlow
force-pushed
the
add-package-parameter-to-install
branch
from
a6f613b to
eaed016
Compare
and package/version.
jpartlow
force-pushed
the
add-package-parameter-to-install
branch
from
eaed016 to
4df5599
Compare
The puppet-strings tool doesn't play nicely with long task descriptions, truncating them in the summary, so I shortened those to fit. Detailed task descriptions will be in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, openvox_bootstrap::install will still install openvox-agent, but you can override
packageto install another package, such as openvox-server or openvoxdb from the collection.Also, this pr adds a REFERENCE.md generated with puppet-strings, and minimal changes needs to validate in the main pr_testing workflow that a given pr's REFERENCE.md is up to date with the state of the module.