(gh-20) Download with curl --fail instead of --fail-with-body #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jpartlow
force-pushed
the
gh-20-curl-versions-predate-fail-with-body
branch
from
631ee09 to
501930f
Compare
The --fail-with-body parameter was introduced into curl in in 7.76.0 - March 31 2021 (https://curl.se/changes.html). Older vms we are still testing on may have curls predating this version. For example, the rocky8/alma8 vm images have curl 7.61.1 - September 5 2018. Switching the --fail provides basically the same semantics, but without capturing the full response body in the file. Not trying to scrape the respone, atm, though, so this should be fine.
jpartlow
force-pushed
the
gh-20-curl-versions-predate-fail-with-body
branch
4 times, most recently
from
b40c01b to
43e75e2
Compare
Provides a consistent way of verifying the installed version for acceptance testing. Version comparison is handled by Ruby's Gem::Version class. The agent's ruby is used to run the task. If Bolt knows the target has the puppet-agent, then the check.rb is run. If Bolt doesn't know whether puppet-agent is in place, the shell script is run, which will check for the puppet binary and either fail or kick off the check.rb if found.
...in place of some of the adhoc shell scripts.
* Removes shellcheck disable SC2154 where defaults were provided for PT_* variables, thereby ensuring existence of a value. * Switches to declare PT__installdir to pass shellcheck for that case. * Removes erroneous single quotes from defaults, since they are taken literally in the default.
These were included to help when calling tasks/install_linux.sh directly, but the script itself has these defaults, and they should not need to be passed in now.
jpartlow
force-pushed
the
gh-20-curl-versions-predate-fail-with-body
branch
from
43e75e2 to
11e6d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The --fail-with-body parameter was introduced into curl in in 7.76.0 - March 31 2021 (https://curl.se/changes.html). Older vms we are still testing on may have curls predating this version. For example, the rocky8/alma8 vm images have curl 7.61.1 - September 5 2018.
Switching the --fail provides basically the same semantics, but without capturing the full response body in the file. Not trying to scrape the respone, atm, though, so this should be fine.
This Pull Request (PR) fixes the following issues
Fixes #20