Skip to content

Conversation

Copy link
Contributor Author

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I got some slight differences in other releases with my local version of GCG. I just left those sections alone and included the 13.3 section, but if someone prefers, I can push the file as-generated.

@wyardley
Copy link
Contributor Author

FWIW, it seems like sometimes GCG is now including both an issue and the PR that fixed / closed it if both are tagged as 'enhancement'. I'm using a combination of removing labels or adding skip-changelog to fix that.

The other issue I'm seeing is some older entries where GH usernames changed or are no longer extant. I'm letting this update the one where the user changed, but leaving the one that changed to "ghost" as it was for now.

@wyardley wyardley force-pushed the wyardley/release/13_3_0 branch from 2e38140 to 48d16d7 Compare May 18, 2024 22:25
@wyardley wyardley force-pushed the wyardley/release/13_3_0 branch from 48d16d7 to 00d2e34 Compare May 18, 2024 22:27
@wyardley wyardley requested a review from bastelfreak May 18, 2024 22:28
@bastelfreak
Copy link
Member

@wyardley good and bad news! good: #915 passes now. bad: we're not compatible for puppet 8 yet, so I reverted 701ab63. I wanted to do that in the modulesync branch but did it on master. And I'm not sure how we should properly address this. I can revert the revert and provide that as a new PR?

@wyardley
Copy link
Contributor Author

Wow, thanks for getting modulesync working. Do you want to squash the other commits in 915, and add the revert as another commit there? Or a separate revert commit is also fine

@bastelfreak
Copy link
Member

lets see, I will try to add official puppet 8 support

@wyardley wyardley force-pushed the wyardley/release/13_3_0 branch 2 times, most recently from 740d7b0 to 8abca58 Compare May 19, 2024 04:48
@wyardley wyardley force-pushed the wyardley/release/13_3_0 branch from 8abca58 to eeafb3b Compare May 19, 2024 05:09
@bastelfreak bastelfreak merged commit 872848c into voxpupuli:master May 19, 2024
@wyardley wyardley deleted the wyardley/release/13_3_0 branch May 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants